Skip to content

Use correct arch when publishing app#114

Merged
Gérald Barré (meziantou) merged 1 commit into
mainfrom
feature/FENG-905_publish
Aug 18, 2025
Merged

Use correct arch when publishing app#114
Gérald Barré (meziantou) merged 1 commit into
mainfrom
feature/FENG-905_publish

Conversation

@meziantou
Copy link
Copy Markdown
Contributor

@meziantou Gérald Barré (meziantou) commented Aug 18, 2025

Jira issue link: FENG-905

@meziantou Gérald Barré (meziantou) requested review from a team and Copilot August 18, 2025 16:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Dockerfile to support multi-architecture builds by dynamically selecting the correct .NET runtime identifier based on the target platform. Instead of hardcoding the x64 architecture, the build process now conditionally publishes for either amd64 (x64) or arm64 architectures.

  • Replaces hardcoded linux-musl-x64 runtime identifier with conditional logic
  • Adds ARG TARGETPLATFORM to capture the build platform during Docker build
  • Uses shell conditional to select appropriate runtime identifier (linux-musl-x64 or linux-musl-arm64)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Dockerfile
@meziantou Gérald Barré (meziantou) merged commit 5f34907 into main Aug 18, 2025
5 checks passed
@meziantou Gérald Barré (meziantou) deleted the feature/FENG-905_publish branch August 18, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants